Fix high latency when websocket connection fails#655
Merged
fusesource-ci merged 2 commits intofabric8io:masterfrom Feb 9, 2017
Merged
Fix high latency when websocket connection fails#655fusesource-ci merged 2 commits intofabric8io:masterfrom
fusesource-ci merged 2 commits intofabric8io:masterfrom
Conversation
Member
|
ok to test |
iocanel
approved these changes
Feb 9, 2017
Member
iocanel
left a comment
iocanel
left a comment
There was a problem hiding this comment.
Just looking at the code, it looks good to me with just a tiny little nice to have.
| return; | ||
| } | ||
|
|
||
| if (response != null && response.code() == HTTP_OK) { |
Member
There was a problem hiding this comment.
I would group this block with the rest of the if then else that take place when response != null.
Definitely not a blocker though!
jimmidyson
approved these changes
Feb 9, 2017
Contributor
|
Thanks again! [merge] We'll kick off a release as soon as this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #652 based on #652 (comment)
/cc @jimmidyson @iocanel